Skip to content

Conversation

@Singham-24
Copy link
Contributor

Fixes i18n key handling for CAP-based cards generator in preview-middleware.

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: 43963bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cla-assistant
Copy link

cla-assistant bot commented Oct 15, 2025

CLA assistant check
All committers have signed the CLA.

@Singham-24 Singham-24 marked this pull request as ready for review October 15, 2025 14:16
@Singham-24 Singham-24 requested a review from a team as a code owner October 15, 2025 14:16
@heimwege heimwege added the preview-middleware @sap-ux/preview-middleware label Oct 16, 2025
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • review comments have been addressed
  • changeset ok
  • code coverage is good
  • did NOT test manually

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

@Singham-24 Singham-24 merged commit db63f7b into main Nov 4, 2025
16 checks passed
@Singham-24 Singham-24 deleted the fix/preview-middleware/i18n-handling-for-cards-generator branch November 4, 2025 05:08
devinea added a commit that referenced this pull request Nov 4, 2025
* origin/main:
  chore: apply latest changesets
  chore: update pipeline to publish extensions as draft (#3807)
  chore: apply latest changesets
  fix(fiori-annotation-api): move and delete  (#3785)
  chore: apply latest changesets
  generalise pipeline config (#3804)
  chore: apply latest changesets
  test config updates (#3803)
  chore: apply latest changesets
  correct sap systems extension naming in config (#3802)
  chore: apply latest changesets
  pipeline config test for extension (#3801)
  chore: apply latest changesets
  fix(preview-middleware): i18n handling for cards generator (#3736)
  chore: apply latest changesets
  feat(preview-middleware): enable card generator for CAP projects (#3737)
  chore: apply latest changesets
  Feat: add question to store the system created/modified via generator, add warning to password input (#3720)
devinea added a commit that referenced this pull request Nov 5, 2025
* origin/main: (85 commits)
  lint error handling for forks
  fix: update repository reference in checkout step of lint workflow (#3808)
  chore: apply latest changesets
  chore: add badge to changelog and deep link to package to readme.md files (#3791)
  chore: apply latest changesets
  chore: update pipeline to publish extensions as draft (#3807)
  chore: apply latest changesets
  fix(fiori-annotation-api): move and delete  (#3785)
  chore: apply latest changesets
  generalise pipeline config (#3804)
  chore: apply latest changesets
  test config updates (#3803)
  chore: apply latest changesets
  correct sap systems extension naming in config (#3802)
  chore: apply latest changesets
  pipeline config test for extension (#3801)
  chore: apply latest changesets
  fix(preview-middleware): i18n handling for cards generator (#3736)
  chore: apply latest changesets
  feat(preview-middleware): enable card generator for CAP projects (#3737)
  ...
eouin added a commit that referenced this pull request Nov 11, 2025
…ter/building-block-custom-filter

* 'main' of github.com:SAP/open-ux-tools: (77 commits)
  chore: apply latest changesets
  test config updates (#3803)
  chore: apply latest changesets
  correct sap systems extension naming in config (#3802)
  chore: apply latest changesets
  pipeline config test for extension (#3801)
  chore: apply latest changesets
  fix(preview-middleware): i18n handling for cards generator (#3736)
  chore: apply latest changesets
  feat(preview-middleware): enable card generator for CAP projects (#3737)
  chore: apply latest changesets
  Feat: add question to store the system created/modified via generator, add warning to password input (#3720)
  chore: apply latest changesets
  Feat: warn the user when trying to store ABAP On Premise system with credentials (#3797)
  chore: apply latest changesets
  feat(preview-middleware): add log message for viewCache redirect (#3798)
  chore: apply latest changesets
  fix(odata-service-inquirer): 36119 default table message (#3777)
  chore: apply latest changesets
  3792/handle missing mta binary (#3793)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview-middleware @sap-ux/preview-middleware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants