-
Notifications
You must be signed in to change notification settings - Fork 53
fix(preview-middleware): i18n handling for cards generator #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(preview-middleware): i18n handling for cards generator #3736
Conversation
🦋 Changeset detectedLatest commit: 43963bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heimwege
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- review comments have been addressed
- changeset ok
- code coverage is good
- did NOT test manually
|
* origin/main: chore: apply latest changesets chore: update pipeline to publish extensions as draft (#3807) chore: apply latest changesets fix(fiori-annotation-api): move and delete (#3785) chore: apply latest changesets generalise pipeline config (#3804) chore: apply latest changesets test config updates (#3803) chore: apply latest changesets correct sap systems extension naming in config (#3802) chore: apply latest changesets pipeline config test for extension (#3801) chore: apply latest changesets fix(preview-middleware): i18n handling for cards generator (#3736) chore: apply latest changesets feat(preview-middleware): enable card generator for CAP projects (#3737) chore: apply latest changesets Feat: add question to store the system created/modified via generator, add warning to password input (#3720)
* origin/main: (85 commits) lint error handling for forks fix: update repository reference in checkout step of lint workflow (#3808) chore: apply latest changesets chore: add badge to changelog and deep link to package to readme.md files (#3791) chore: apply latest changesets chore: update pipeline to publish extensions as draft (#3807) chore: apply latest changesets fix(fiori-annotation-api): move and delete (#3785) chore: apply latest changesets generalise pipeline config (#3804) chore: apply latest changesets test config updates (#3803) chore: apply latest changesets correct sap systems extension naming in config (#3802) chore: apply latest changesets pipeline config test for extension (#3801) chore: apply latest changesets fix(preview-middleware): i18n handling for cards generator (#3736) chore: apply latest changesets feat(preview-middleware): enable card generator for CAP projects (#3737) ...
…ter/building-block-custom-filter * 'main' of github.com:SAP/open-ux-tools: (77 commits) chore: apply latest changesets test config updates (#3803) chore: apply latest changesets correct sap systems extension naming in config (#3802) chore: apply latest changesets pipeline config test for extension (#3801) chore: apply latest changesets fix(preview-middleware): i18n handling for cards generator (#3736) chore: apply latest changesets feat(preview-middleware): enable card generator for CAP projects (#3737) chore: apply latest changesets Feat: add question to store the system created/modified via generator, add warning to password input (#3720) chore: apply latest changesets Feat: warn the user when trying to store ABAP On Premise system with credentials (#3797) chore: apply latest changesets feat(preview-middleware): add log message for viewCache redirect (#3798) chore: apply latest changesets fix(odata-service-inquirer): 36119 default table message (#3777) chore: apply latest changesets 3792/handle missing mta binary (#3793) ...



Fixes i18n key handling for CAP-based cards generator in preview-middleware.